Fix relative redirects regression. Closes #13607 (#13616)

lfilho · ematipico · web-flow · commit d475afcae725 · 2025-04-16T14:11:37.000+01:00
Co-authored-by: Emanuele Stoppa &lt;my.burning@gmail.com&gt;
diff --git a/.changeset/tasty-cities-warn.md b/.changeset/tasty-cities-warn.md
@@ -0,0 +1,5 @@
+---
+'astro': patch
+---
+
+Fixes a regression where relative static redirects didn't work as expected.
diff --git a/packages/astro/src/core/routing/manifest/create.ts b/packages/astro/src/core/routing/manifest/create.ts
@@ -357,12 +357,9 @@ function createRedirectRoutes(
 			destination = to.destination;
 		}
 
-		// URLs that don't start with leading slash should be considered external
-		if (!destination.startsWith('/')) {
-			// check if the link starts with http or https; if not, log a warning
-			if (!/^https?:\/\//.test(destination) && !URL.canParse(destination)) {
-				throw new AstroError(UnsupportedExternalRedirect);
-			}
+		// check if the link starts with http or https; if not, throw an error
+		if (URL.canParse(destination) && !/^https?:\/\//.test(destination)) {
+			throw new AstroError(UnsupportedExternalRedirect);
 		}
 
 		routes.push({
diff --git a/packages/astro/test/redirects.test.js b/packages/astro/test/redirects.test.js
@@ -131,6 +131,7 @@ describe('Astro.redirect', () => {
 						'/more/old/[dynamic]/[route]': '/more/[dynamic]/[route]',
 						'/more/old/[...spread]': '/more/new/[...spread]',
 						'/external/redirect': 'https://example.com/',
+						'/relative/redirect': '../../test',
 					},
 				});
 				await fixture.build();
@@ -214,6 +215,12 @@ describe('Astro.redirect', () => {
 				assert.equal(html.includes('http-equiv="refresh'), true);
 				assert.equal(html.includes('url=https://example.com/'), true);
 			});
+
+			it('supports redirecting to a relative destination', async () => {
+				const html = await fixture.readFile('/relative/redirect/index.html');
+				assert.equal(html.includes('http-equiv="refresh'), true);
+				assert.equal(html.includes('url=../../test'), true);
+			});
 		});
 
 		describe('dev', () => {

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +'astro': patch
 +---
++
 +Fixes a regression where relative static redirects didn't work as expected.
Original file line number	Diff line number	Diff line change
`@@ -357,12 +357,9 @@ function createRedirectRoutes(`
`357`	`357`	`destination = to.destination;`
`358`	`358`	`}`
`359`	`359`
`360`		`- // URLs that don't start with leading slash should be considered external`
`361`		`- if (!destination.startsWith('/')) {`
`362`		`- // check if the link starts with http or https; if not, log a warning`
`363`		`- if (!/^https?:\/\//.test(destination) && !URL.canParse(destination)) {`
`364`		`- throw new AstroError(UnsupportedExternalRedirect);`
`365`		`- }`
	`360`	`+ // check if the link starts with http or https; if not, throw an error`
	`361`	`+ if (URL.canParse(destination) && !/^https?:\/\//.test(destination)) {`
	`362`	`+ throw new AstroError(UnsupportedExternalRedirect);`
`366`	`363`	`}`
`367`	`364`
`368`	`365`	`routes.push({`