Fix JPEG image size determination#12542
Merged
ematipico merged 2 commits intowithastro:mainfrom Nov 27, 2024
Merged
Conversation
🦋 Changeset detectedLatest commit: 6c4ad21 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
CodSpeed Performance ReportMerging #12542 will not alter performanceComparing Summary
|
Member
|
This folder is a vendored version of Since the upstream package here is rarely updated, it should be fine to update our copy, though |
Princesseuh
reviewed
Nov 27, 2024
Princesseuh
approved these changes
Nov 27, 2024
Member
Princesseuh
left a comment
There was a problem hiding this comment.
Code looks great, thank you!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12530
Changes
0xFFblocks in the JPEG image size calculation. Instead of skipping one byte, the entire block is now skipped, improving performance and accuracy.0xFFblocks, leading to incorrect image size determination. This change ensures that only valid JPEG blocks are processed, skipping unnecessary metadata blocks.Testing
This change was tested manually by verifying that the image size calculation is accurate for JPEG images with various metadata blocks. No new tests were added, as the existing tests should cover this scenario.
Docs
This change does not affect user behavior, so no documentation updates are required. The fix is internal to the JPEG image size calculation logic and does not introduce any new features or APIs.