Fix JPEG image size determination (#12542)

kadykov · web-flow · commit 65e50eb7b6d7 · 2024-11-27T13:05:56.000Z
diff --git a/.changeset/bright-pants-trade.md b/.changeset/bright-pants-trade.md
@@ -0,0 +1,5 @@
+---
+'astro': patch
+---
+
+Fix JPEG image size determination
diff --git a/packages/astro/src/assets/utils/vendor/image-size/types/jpg.ts b/packages/astro/src/assets/utils/vendor/image-size/types/jpg.ts
@@ -122,7 +122,8 @@ export const JPG: IImage = {
 
       // Every JPEG block must begin with a 0xFF
       if (input[i] !== 0xff) {
-        input = input.slice(1)
+        // Change from upstream: fix non-0xFF blocks skipping
+        input = input.slice(i)
         continue
       }
 

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +'astro': patch
 +---
++
 +Fix JPEG image size determination
Original file line number	Diff line number	Diff line change
`@@ -122,7 +122,8 @@ export const JPG: IImage = {`
`122`	`122`
`123`	`123`	`// Every JPEG block must begin with a 0xFF`
`124`	`124`	`if (input[i] !== 0xff) {`
`125`		`- input = input.slice(1)`
	`125`	`+ // Change from upstream: fix non-0xFF blocks skipping`
	`126`	`+ input = input.slice(i)`
`126`	`127`	`continue`
`127`	`128`	`}`
`128`	`129`