Fix script injection during build#12392
Merged
ematipico merged 16 commits intowithastro:mainfrom Nov 14, 2024
Merged
Conversation
Member
|
Should we add new tests? |
Contributor
Author
|
Yes, I will add.
…On Thu, Nov 7, 2024 at 2:52 AM Emanuele Stoppa ***@***.***> wrote:
Should we add new tests?
—
Reply to this email directly, view it on GitHub
<#12392 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AH7EZBDMCL7AB2SUBWMDFXLZ7ML5VAVCNFSM6AAAAABRKFCXM2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRRGU2DIOJWGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Contributor
Author
Added. Thanks for your patience. Let me know if any changes are needed. |
ematipico
reviewed
Nov 12, 2024
| value: id, | ||
| }; | ||
| } | ||
| for (const pageData of getPageDatasByHoistedScriptId(internals, facadeId)) { |
Member
There was a problem hiding this comment.
As you noticed from the Github bot comments, settings isn't used anymore, so we can remove it
Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
injectRoute shared entrypoint during SSR
Member
|
@apatel369 the build is failing, can you please fix it? |
Contributor
Author
Fixed. |
ematipico
approved these changes
Nov 14, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Closes #12171
This pull request addresses issue #12171 where shared entrypoints in
injectRoute()remove client-side scripts in SSR builds. The changes ensure that client-side scripts are correctly included for all routes using the same entrypoint.Testing
added tests
Docs
Internal bug fix so docs update not needed