Skip to content

Fix script injection during build #12392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ematipico merged 16 commits into from
Nov 14, 2024
Merged

Fix script injection during build #12392

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
ca1cba3
fix issue with scripts in `injectRoute` shared entrypoint
apatel369 Nov 7, 2024
40584b4
add changeset
apatel369 Nov 7, 2024
91503c8
Merge branch 'withastro:main' into arpan-#12171
apatel369 Nov 10, 2024
c766c32
add tests
apatel369 Nov 11, 2024
32a0832
add params
apatel369 Nov 11, 2024
fbd137d
rename
apatel369 Nov 11, 2024
f15133d
fix error
apatel369 Nov 11, 2024
71a460b
add default value
apatel369 Nov 11, 2024
b2d4b4b
fix error
apatel369 Nov 11, 2024
1a576a6
fix tests
apatel369 Nov 11, 2024
5fc06ab
format
apatel369 Nov 11, 2024
5075448
Merge branch 'main' into arpan-#12171
apatel369 Nov 11, 2024
7ee36da
Update .changeset/slimy-pets-lick.md
apatel369 Nov 12, 2024
f1a8617
remove unused
apatel369 Nov 12, 2024
aa5e8a0
fix args
apatel369 Nov 12, 2024
54cd066
Merge branch 'main' into arpan-#12171
apatel369 Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add default value
  • Loading branch information
@apatel369
apatel369 committed Nov 11, 2024
commit 71a460ba9539627cabf3f66f8fbfcb611827d338
2 changes: 1 addition & 1 deletion packages/astro/test/reuse-injected-entrypoint.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ describe('Reuse injected entrypoint', () => {
await fixture.build();
});

routes.forEach(({ description, url, fourOhFour, h1, p, htmlMatch, hasScript }) => {
routes.forEach(({ description, url, fourOhFour, h1, p, htmlMatch, hasScript = false }) => {
const isEndpoint = htmlMatch && !h1 && !p;

it(description, async () => {
Expand Down