fix(types): allow transaction to be null (#13093)

yjwong · web-flow · commit ced4dc785f24 · 2021-03-13T02:23:54.000-03:00
diff --git a/types/lib/model.d.ts b/types/lib/model.d.ts
@@ -35,7 +35,7 @@ export interface Transactionable {
   /**
    * Transaction to run query under
    */
-  transaction?: Transaction;
+  transaction?: Transaction | null;
 }
 
 export interface SearchPathable {
diff --git a/types/test/transaction.ts b/types/test/transaction.ts
@@ -78,3 +78,9 @@ async function nestedTransact() {
   });
   await tr.commit();
 }
+
+async function excludeFromTransaction() {
+  await sequelize.transaction(async t =>
+    await sequelize.query('SELECT 1', { transaction: null })
+  );
+}

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ export interface Transactionable {`
`35`	`35`	`/**`
`36`	`36`	`* Transaction to run query under`
`37`	`37`	`*/`
`38`		`- transaction?: Transaction;`
	`38`	`+ transaction?: Transaction \| null;`
`39`	`39`	`}`
`40`	`40`
`41`	`41`	`export interface SearchPathable {`