Hello! Thanks!

I wish for this change to also be backported to v5. How do I go about doing that?

You create a new branch off the v5 branch, do the same changes you did here (including a test, please), and open a new pull request selecting v5 as the target branch (instead of main). And write something like this in its description:

This PR is a backport of #13093 into v5

I tried running npm run test-typings locally but got this output:

> sequelize@0.0.0-development test-typings /home/yjwong/Documents/sequelize
> tsc -b types/tsconfig.json && tsc -b types/test/tsconfig.json

types/test/define.ts:30:43 - error TS2511: Cannot create an instance of an abstract class.

30   expectTypeOf<UserModel>().toMatchTypeOf(new User());
                                             ~~~~~~~~~~

types/test/define.ts:63:50 - error TS2511: Cannot create an instance of an abstract class.

63   expectTypeOf<UntypedUserModel>().toMatchTypeOf(new UntypedUser());
                                                    ~~~~~~~~~~~~~~~~~


Found 2 errors.

These errors doesn't seem to be related to the tests I added.

@yjwong Hmm, that's weird, but since tests are passing on GitHub Actions, don't worry about it. Just in case, can you confirm what is your TS local version?

@papb I found out why, I manually installed TypeScript 4.1.x using npm install --save-dev typescript@~4.1 and it ran without error. Seems like it's more of an issue with TypeScript 4.2.x.

Seems like it's related to this change: https://devblogs.microsoft.com/typescript/announcing-typescript-4-2/#abstract-construct-signatures

But that's probably a different issue altogether.

🎉 This PR is included in version 6.5.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀