Repository navigation
Ignore aiosqlite 0.22.0 - #1729
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1729 +/- ##
=======================================
Coverage 99.29% 99.29%
=======================================
Files 63 63
Lines 12272 12272
=======================================
Hits 12186 12186
Misses 86 86 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR restricts the aiosqlite dependency to exclude version 0.22.0 due to a race condition where await db.close() doesn't properly wait for the background thread to join, despite changes to the background thread behavior in that version.
- Adds upper bound constraint to exclude aiosqlite 0.22.0
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "attrs", | ||
| "aiohttp", | ||
| "aiosqlite>=0.20.0", | ||
| "aiosqlite>=0.20.0,<0.22.0", |
There was a problem hiding this comment.
The version constraint <0.22.0 only excludes version 0.22.0 specifically. If version 0.23.0 or later is released with the same race condition, it will still be allowed by this constraint. Consider using !=0.22.0 instead to only exclude the problematic version, or add an upper bound like <0.23.0 if you want to prevent automatic upgrades to untested versions until the race condition is confirmed fixed.
There was a problem hiding this comment.
How will 0.23.0 be allowed by >=0.20.0,<0.22.0?
0.22.0 changes the background thread behavior but does not fix the underlying race condition where
await db.close()doesn't actually wait for the thread to join.