task to lesson 3 - #9
Open
zagidulin wants to merge 1 commit into
Open
Conversation
Tardigrada777
approved these changes
Sep 1, 2020
Tardigrada777
left a comment
There was a problem hiding this comment.
В целом отлично, но я рекомендую обратить особое внимание на форматирование кода, аккуратность, пробелы и отступы и проч.
| // для инициализации возможности удаления изменения количесвта товара при "раскрытии" корзины | ||
| if (this.shopCartList.length > 0) { | ||
| let changeShopCart = document.querySelector('.basket_container'); | ||
| changeShopCart.addEventListener('click', (event) => { |
There was a problem hiding this comment.
Не самое эффективное решение. Рекомендую обратить внимание на стратегию делегирования событий. https://learn.javascript.ru/event-delegation
| this.shopCartList = []; | ||
| } | ||
|
|
||
| _getShopCartList() { |
|
|
||
| function makeGETRequest (url, callback) { | ||
| let xhr; | ||
| if (window .XMLHttpRequest) { |
There was a problem hiding this comment.
Между именем объекта и точкой пробел не ставится.
| this.goods = []; | ||
| } | ||
|
|
||
| fetchGoods(cb) { |
There was a problem hiding this comment.
Отлично, прокинули колбек в метод!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.