task to lesson 6 - #14
Open
zagidulin wants to merge 2 commits into
Open
Conversation
Tardigrada777
approved these changes
Sep 12, 2020
Tardigrada777
left a comment
There was a problem hiding this comment.
Хорошо. Проработайте мои комментарии.
| } | ||
|
|
||
| render() { | ||
| this.#getShopCartList(this.shopCartList); |
There was a problem hiding this comment.
Не думаю, что получать товары каждый раз при рендере - это хорошая идея. Лучше вынести рендер отдельно от получения данных
|
|
||
| xhr.onreadystatechange = function () { | ||
| if (xhr.readyState === 4) { | ||
| if (xhr.status === 200) { |
There was a problem hiding this comment.
Хорошо, эта проверка действительно тут нужна.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.