Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Refactors spell resource costs#22015

Merged
Moltijoe merged 9 commits into
yogstation13:masterfrom
Moltijoe:SpellResourceRefactor
Jun 2, 2024
Merged

Refactors spell resource costs#22015
Moltijoe merged 9 commits into
yogstation13:masterfrom
Moltijoe:SpellResourceRefactor

Conversation

@Moltijoe

@Moltijoe Moltijoe commented May 6, 2024

Copy link
Copy Markdown
Contributor

When i was working on reworking darkspawns i kept seeing how vampires had a snowflake variable for blood cost
I hated it, and hated that i was doing the same thing for darkspawns
so i've refactored it into using an associative list and signals

Why is this good for the game?

it makes it easier to make additional antag resources for use by spells

Testing

image
image

🆑
experimental: Darkspawn psi and Vampire blood costs have been refactored, please report any wonkiness
/:cl:

@Moltijoe Moltijoe added the Refactor Makes old code less shit label May 6, 2024
@github-actions github-actions Bot added the Admin This PR affects administrators label May 6, 2024
Comment thread code/modules/spells/spell.dm Outdated
Comment thread yogstation/code/modules/antagonists/darkspawn/darkspawn_antag.dm
@iamthesilly iamthesilly added the Merge conflict Files are conflicting with current live changes. label May 11, 2024
@Moltijoe Moltijoe removed the Merge conflict Files are conflicting with current live changes. label May 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Admin This PR affects administrators Refactor Makes old code less shit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants