Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

You cannot make cult golems unless you are cult#10129

Merged
JamieD1 merged 1 commit into
yogstation13:masterfrom
ynot01:cult-metal-golems
Oct 27, 2020
Merged

You cannot make cult golems unless you are cult#10129
JamieD1 merged 1 commit into
yogstation13:masterfrom
ynot01:cult-metal-golems

Conversation

@ynot01
Copy link
Copy Markdown
Contributor

@ynot01 ynot01 commented Oct 23, 2020

Intent of your Pull Request

Only one with forbidden knowledge could hope to work this metal...

tested and working

Changelog

🆑
tweak: You can no longer make cult golems unless you are cult
/:cl:

@Yogbot-13 Yogbot-13 added the Tweak This PR contains changes to the game. label Oct 23, 2020
@ghost
Copy link
Copy Markdown

ghost commented Oct 23, 2020

why

@ynot01
Copy link
Copy Markdown
Contributor Author

ynot01 commented Oct 23, 2020

why

non-cultists should not have access to overpowered cult material, the same reason noncultists cannot use cult metal or other cult gear

@boodaliboo
Copy link
Copy Markdown
Contributor

why? i understand cult golem but not clock golem

@Marmio64
Copy link
Copy Markdown
Contributor

i wouldn't say either of these are OP. Sure they are powerful, but do they need to be removed from random players? However, if this is added i'll probably add a way to sell cult metal in cargo (if you can't already, i dont know) so that it isn't totally useless.

Copy link
Copy Markdown
Contributor

@jcatjmeow jcatjmeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine to me

@Hopekz
Copy link
Copy Markdown
Contributor

Hopekz commented Oct 23, 2020

While not "OP" it seems like an oversight.
I don't think people can use cult metals normally to make things so it seems like inconsistent behavior to keep this in.

@UselessTheremin
Copy link
Copy Markdown
Contributor

Sad cogger noises

@ghost
Copy link
Copy Markdown

ghost commented Oct 24, 2020

@ynot01 @Hopekz it is neither OP nor an oversight

it was very much intended behavior

much like the chaplain can create crew-sided constructs (which is intended) if they get their hands on a construct shell and a purified soulstone xenobiology can create runic golems if the crew recovers runed metal

@ghost
Copy link
Copy Markdown

ghost commented Oct 24, 2020

also the PR that added runic golems intentionally specified they were meant to look culty but not be necessarily cult sided

@Hopekz
Copy link
Copy Markdown
Contributor

Hopekz commented Oct 24, 2020

also the PR that added runic golems intentionally specified they were meant to look culty but not be necessarily cult sided

Are you referring to this PR?
tgstation/tgstation#25028

That PR is on TG.
We have not had this discussion yet on yogs. The PR that added the runic golems to yogs also didn't mention anything like that.

Remember; we are not TG so what might be intentional there might not be intentional here as it was added here in the form of a lazy port without any real discussion, making it a potential oversight.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Tweak This PR contains changes to the game.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants