Skip to content

Write test for issue 15#16

Merged
roxblnfk merged 2 commits intoyiisoft:masterfrom
epifrin:master
Nov 29, 2020
Merged

Write test for issue 15#16
roxblnfk merged 2 commits intoyiisoft:masterfrom
epifrin:master

Conversation

@epifrin
Copy link
Copy Markdown
Contributor

@epifrin epifrin commented Nov 28, 2020

Has written test that show bug explained in issue 15

@samdark samdark added the type:test Test label Nov 28, 2020
@roxblnfk roxblnfk self-assigned this Nov 29, 2020
roxblnfk added a commit to roxblnfk/yii-error-handler that referenced this pull request Nov 29, 2020
@roxblnfk
Add HeaderHelper tests; Fix case from yiisoft#16
0230148
@roxblnfk roxblnfk mentioned this pull request Nov 29, 2020
Merged
@roxblnfk
Copy link
Copy Markdown
Member

roxblnfk commented Nov 29, 2020

Thank, you helped detect that:

  • We forgot to transfer tests for HeaderHelper to this repository
  • HeaderHelper did not work correctly if the list of header values was passed simultaneously in strings and arrays

roxblnfk
roxblnfk approved these changes Nov 29, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@roxblnfk roxblnfk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, your PR remains useful with one amendment: you can delete the new test case, since it related to the HtmlHelper. And this test case i added in #18

Comment thread tests/ErrorCatcherTest.php Outdated
@roxblnfk roxblnfk requested a review from samdark November 29, 2020 12:52
@samdark
Copy link
Copy Markdown
Member

samdark commented Nov 29, 2020

@roxblnfk I've merged your fix. Would you please take part of tests that's needed? @epifrin please check if it's alright now.

@roxblnfk roxblnfk merged commit 1bee53d into yiisoft:master Nov 29, 2020
@epifrin
Copy link
Copy Markdown
Contributor Author

epifrin commented Nov 29, 2020

@roxblnfk I've merged your fix. Would you please take part of tests that's needed? @epifrin please check if it's alright now.

Yes, it's alright now. Thank you!

@shuangjie shuangjie mentioned this pull request Apr 19, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roxblnfk roxblnfk roxblnfk approved these changes

@samdark samdark Awaiting requested review from samdark

Assignees

@roxblnfk roxblnfk

Labels

type:test Test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@epifrin @roxblnfk @samdark