Skip to content

Add solution providers #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xepozz wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Add solution providers #127

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
f09026b
Add solution providers
xepozz Jul 18, 2024
85ec4f0
Move providers to config
xepozz Jul 18, 2024
884f7be
Apply fixes from StyleCI
StyleCIBot Jul 18, 2024
a2574a3
Merge branch 'master' into solution
xepozz Aug 4, 2024
b67993d
Allow form controls
xepozz Aug 4, 2024
a2b5afd
Merge remote-tracking branch 'origin/solution' into solution
xepozz Aug 4, 2024
5c2c4b0
Merge branch 'master' into solution
xepozz Oct 14, 2024
7c81988
Merge branch 'master' into solution
xepozz Dec 21, 2024
6e2ceb2
fix test
xepozz Dec 21, 2024
b5e5ddf
Merge branch 'master' into solution
vjik Dec 24, 2024
dd29662
Merge branch 'master' into solution
xepozz Jul 28, 2025
8bf9840
Apply fixes from StyleCI
StyleCIBot Jul 28, 2025
ce78cfc
Apply Rector changes (CI)
xepozz Jul 28, 2025
5d41ab0
refactor: remove generator, pass providers directly
xepozz Jul 28, 2025
e904abf
Apply fixes from StyleCI
StyleCIBot Jul 28, 2025
6371efe
Apply Rector changes (CI)
xepozz Jul 28, 2025
4d1259a
Apply fixes from StyleCI
StyleCIBot Jul 28, 2025
8cfee00
Apply suggestion from @xepozz
xepozz Aug 9, 2025
850326e
Apply suggestion from @xepozz
xepozz Aug 9, 2025
a45baf8
Apply suggestion from @xepozz
xepozz Aug 9, 2025
ff4a1a0
Apply fixes from StyleCI
StyleCIBot Aug 9, 2025
3a8bcc7
Merge branch 'master' into solution
xepozz Aug 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestion from @xepozz
  • Loading branch information
@xepozz
xepozz authored Aug 9, 2025
commit a45baf8f0cfc28832464d03b96eebce933cac065
3 changes: 3 additions & 0 deletions src/Solution/SolutionProviderInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@
*/
interface SolutionProviderInterface
Comment thread
xepozz marked this conversation as resolved.
Comment thread
vjik marked this conversation as resolved.
Comment thread
xepozz marked this conversation as resolved.
Copy link
Copy Markdown
Member

@vjik vjik Aug 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SolutionProviderInterface must be placed into separate package. yiisoft/error-handler is too heavy dependency for packages, that implement SolutionProviderInterface.

Copy link
Copy Markdown
Member Author

@xepozz xepozz Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not about any solution in the air. It's about the specific contract between web, user, application and error.
It shouldn't be separated. At least for now.

Copy link
Copy Markdown
Member

@vjik vjik Aug 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interface should define format of solution. Users of interface should know about format of solution.

Copy link
Copy Markdown
Member Author

@xepozz xepozz Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HTML for sure

{
/**
* Returns true if the implementation may suggest more than regular provider.
*/
public function supports(\Throwable $e): bool;
Comment thread
xepozz marked this conversation as resolved.

/**
Expand Down
Loading