Fix error adding directory name in selecting directory mode#4
Closed
Arcanils wants to merge 1 commit into
Closed
Conversation
Owner
|
I believe that the browser should pick the currently highlighted folder in folder select mode rather than always selecting the folder we are currently in (Windows file picker also seems to select the highlighted folder). Despite that, I agree that it should be easier to select the folder that we are currently in. Adding these lines to the setter function of CurrentPath property will clear the filenameInputField when the path changes, which makes it possible to select the current folder: if( m_folderSelectMode )
filenameInputField.text = string.Empty; |
Author
|
Thx for the reply. Indeed if you view this way, it makes sense.
Anyway, this is a nice work and I wanted to help you fix this behaviour.
Have a nice day.
<https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail>
Garanti
sans virus. www.avast.com
<https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail>
<#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
2017-10-23 23:28 GMT+02:00 Süleyman Yasir KULA <notifications@github.com>:
… I believe that the browser should pick the currently highlighted folder in
folder select mode rather than always selecting the folder we are currently
in (Windows file picker also seems to select the highlighted folder).
Despite that, I agree that it should be easier to select the folder that
we are currently in. Adding these lines to the setter function of
CurrentPath property will clear the filenameInputField when the path
changes, which makes it possible to select the current folder:
if( m_folderSelectMode )
filenameInputField.text = string.Empty;
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFIB2J62D2ddyy9Pp91D4CTcfnMM6XHbks5svQUNgaJpZM4QDAu2>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.