Merged
Conversation
arcanis
reviewed
Jan 31, 2022
Comment on lines
+27
to
+30
|
|
||
| # TODO: Remove once https://github.com/yarnpkg/berry/blob/bd146ccddf95aae9c99c0c48d86b1d8997f1dccf/scripts/e2e-setup-ci.sh#L31-L38 is fixed | ||
| YARN_PNP_ENABLE_ESM_LOADER=true | ||
|
|
Member
Member
Author
There was a problem hiding this comment.
Assuming you meant to link to nodejs/node#41221 then yes, it has been fixed in 17.4.0 but I don't want to upgrade the CI to that version due to the OpenSSL changes causing webpack@4 builds to not work. I'd rather wait for that PR to be backported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
The Docusaurus e2e test started failing at 2022-01-26T20:01:17Z because it tries to import ESM but the ESM loader isn't enabled.
How did you fix it?
Enable the ESM loader
Checklist