Support pybind11 master branch (2.3 dev)#164
Merged
Merged
Conversation
Add a Travis-CI environment variable: PYBIND11_VERSION. All build flavors use it. Also remove unnecessary comments after ifdef.
Member
|
Thanks @yungyuc this looks good! Looking at what is done in pybind11, it seems that we replacing with |
Contributor
Author
|
It works for pybind11 master branch but not v2.2 stable branch. v2.3 changes |
Member
|
Merging! Maybe we should ask the pybind11 to make some of that API truly public. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The macro
PYBIND11_DESCRis removed from pybind11 master (it happened more than a year ago). This is a hack to allow xtensor-python to build.For testing I tweaked the
.travis.yml. Set PYBIND11_VERSION=master environment variable in Travis CI to enable pybind11 master branch.