Backstrides iteration#110
Merged
JohanMabille merged 1 commit intoSep 6, 2017
Merged
Conversation
JohanMabille
reviewed
Sep 6, 2017
| { | ||
| value_type sh = p_a->shape()[m_offset]; | ||
| value_type res = sh == 1 ? 0 : (sh - 1) * p_a->strides()[m_offset]; | ||
| return res; |
Member
There was a problem hiding this comment.
I think taking a pointer on the backstrides object instead of the pyarray would allow to make this method call pyarray_backstrides::operator[] and would avoid code duplication.
| // Returning the address of a temporary | ||
| value_type sh = p_a->shape()[m_offset]; | ||
| value_type res = sh == 1 ? 0 : (sh - 1) * p_a->strides()[m_offset]; | ||
| return &res; |
| auto index = m_offset + n; | ||
| value_type sh = p_a->shape()[index]; | ||
| value_type res = sh == 1 ? 0 : (sh - 1) * p_a->strides()[index]; | ||
| return res; |
08bd46b to
1198e84
Compare
Member
Author
|
Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.