Merged
Conversation
13 tasks
Contributor
hameerabbasi
left a comment
There was a problem hiding this comment.
One minor change, otherwise LGTM.
python package builds and unittests succeed after this fix longintrepr.h moved but is included by Python.h Functions renamed in python/cpython#31657 _PyFloat_Pack2 -> PyFloat_Pack2 _PyFloat_Pack4 -> PyFloat_Pack4 _PyFloat_Pack8 -> PyFloat_Pack8 _PyFloat_Unpack2 -> PyFloat_Unpack2 _PyFloat_Unpack4 -> PyFloat_Unpack4 _PyFloat_Unpack8 -> PyFloat_Unpack8
hameerabbasi
approved these changes
Nov 17, 2023
Contributor
|
Thanks for the contribution, @a-n-n-a-l-e-e! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
python package builds and unittests succeed after the fix. see: NixOS/nixpkgs#268058
longintrepr.h moved but is included by Python.h
Functions renamed in python/cpython#31657
_PyFloat_Pack2 -> PyFloat_Pack2
_PyFloat_Pack4 -> PyFloat_Pack4
_PyFloat_Pack8 -> PyFloat_Pack8
_PyFloat_Unpack2 -> PyFloat_Unpack2
_PyFloat_Unpack4 -> PyFloat_Unpack4
_PyFloat_Unpack8 -> PyFloat_Unpack8