support encryption, transformation - #2
Merged
Conversation
bgaifullin
commented
Feb 16, 2015
Collaborator
- unify exceptions
- support encryption, transformation
- unify error-handling
|
@mehcode, I also need this PR merged. |
Collaborator
|
@bgaifullin Thanks for this awesome PR. Looking at it right now. |
Collaborator
Author
|
There was problem with build on travis. It does not cause of changes in code. I will investigate this problem. |
Collaborator
|
@bgaifullin I can investigate the test crash on travis, that's fine. Could you add a test specific to encryption? |
Collaborator
Author
|
Of course. I am going to add. |
Collaborator
|
@bgaifullin FYI I fixed the travis build on master |
Collaborator
Author
|
I have added tests. |
Collaborator
Author
|
Please, let me know if some other changes is required. |
mehcode
added a commit
that referenced
this pull request
Mar 20, 2015
support encryption, transformation
Collaborator
|
This looks great @bgaifullin; awesome work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.