Skip to content

Fix backend tutorial build#111

Merged
dcherian merged 3 commits into
mainfrom
fix-build
Jun 28, 2022
Merged

Fix backend tutorial build#111
dcherian merged 3 commits into
mainfrom
fix-build

Conversation

@dcherian
Copy link
Copy Markdown
Contributor

@dcherian dcherian commented Jun 28, 2022 •
edited
Loading

Notebook 2 assumed foo.bin exists, but foo.bin was created in Notebook 1. So the build would fail if the notebooks were executed out of order.

Now create foo.bin in both notebooks.

@review-notebook-app
Copy link
Copy Markdown

review-notebook-app Bot commented Jun 28, 2022

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@dcherian dcherian merged commit df8f83c into main Jun 28, 2022
@dcherian dcherian deleted the fix-build branch June 28, 2022 01:48
dcherian added a commit that referenced this pull request Jun 28, 2022
@dcherian
Merge branch 'main' into reorganize-computation
b365ad5 
* main:
  Fix backend tutorial build (#111)
  Overview notebook edits (#110)
  Update plotting notebooks (#107)
@scottyhq
Copy link
Copy Markdown
Contributor

scottyhq commented Jun 28, 2022

good catch! thanks for the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dcherian @scottyhq