Skip to content

Use ramsey/composer-install in Deployment workflow#463

Merged
danielbachhuber merged 1 commit into
wp-cli:mainfrom
wojsmol:update/use-ramsey/composer-install-deploy
Nov 15, 2022
Merged

Use ramsey/composer-install in Deployment workflow#463
danielbachhuber merged 1 commit into
wp-cli:mainfrom
wojsmol:update/use-ramsey/composer-install-deploy

Conversation

@wojsmol
Copy link
Copy Markdown
Contributor

@wojsmol wojsmol commented Nov 15, 2022

No description provided.

@wojsmol wojsmol requested a review from a team as a code owner November 15, 2022 17:41
@danielbachhuber
Copy link
Copy Markdown
Member

@wojsmol Thanks! Out of curiosity, how did you test this?

@wojsmol
Copy link
Copy Markdown
Contributor Author

wojsmol commented Nov 15, 2022

@danielbachhuber
Copy link
Copy Markdown
Member

This is already used for example in https://github.com/wp-cli/.github/blob/3d55c717628f31b7d688dc9b79d8664ac2e13971/.github/workflows/reusable-testing.yml#L42-L49

@wojsmol Sounds good. I'll verify the deployment runs post-merge.

@danielbachhuber danielbachhuber added this to the 2.8.0 milestone Nov 15, 2022
@danielbachhuber danielbachhuber added the scope:distribution Related to distribution label Nov 15, 2022
@danielbachhuber danielbachhuber merged commit f63c8e6 into wp-cli:main Nov 15, 2022
@wojsmol wojsmol deleted the update/use-ramsey/composer-install-deploy branch November 15, 2022 21:14
@danielbachhuber
Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope:distribution Related to distribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants