Conversation
scribu
pushed a commit
that referenced
this pull request
Nov 29, 2013
WP_CLI::add_action() and WP_CLI::do_action() are confusing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exhibit A: #844 (comment)
They have the same names as the WordPress API (
add_action()anddo_action()), yet they don't inter-operate and don't even accept all of the same parameters.One solution would be to give them different names, like
WP_CLI::add_hook().Another solution would be to copy all the code from their WP counterparts. This would mean that both WP-CLI events and WP events would reside in the same namespace. Need to study the implications of this further.