Skip to content

Introduce WP_CLI::runcommand(), the best way to run WP-CLI commands#3605

Merged
danielbachhuber merged 20 commits into
masterfrom
3139-runcommand
Nov 27, 2016
Merged

Introduce WP_CLI::runcommand(), the best way to run WP-CLI commands#3605
danielbachhuber merged 20 commits into
masterfrom
3139-runcommand

Conversation

@danielbachhuber
Copy link
Copy Markdown
Member

@danielbachhuber danielbachhuber commented Nov 24, 2016 •
edited
Loading

  • Launch a new process, rendering output.
  • Launch a new process, capturing output.
  • Reuse existing process, rendering output.
  • Reuse existing process, capturing output.
  • Ensure environment variables and WP-CLI config are passed through when launching new process.
  • Prevent halting script execution when reusing existing process.
  • Return command execution as full object, or specific return values.
  • Abstract command parsing to Utils\parse_str_to_argv() with tests.
  • Use parse=json to parse JSON output.
  • Use WP_CLI::runcommand() where ::launch_self() is currently used.
  • PHPDoc with examples.

Fixes #3139

@danielbachhuber danielbachhuber added this to the 1.0.0 milestone Nov 24, 2016
@danielbachhuber
--capture makes more sense as --return
0404d89
@danielbachhuber
Require PHP 5.4 to prevent error notice failures
1844d6a
@danielbachhuber
Pass WP-CLI environment variables through when launching new process
a160df6
@danielbachhuber
Add testcase that installed packages work
c986d65
@danielbachhuber
Support returning entire execution object, or specific items
478d42d
@danielbachhuber
Return an object, to replicate behavior of ::launch_self()
e7eea7d
@danielbachhuber
Use WP_CLI::runcommand() in wp core update-db --network
438e377
@danielbachhuber
Cast as array for the purposes of the test
8a1bc6b
@danielbachhuber
Use parse=json to parse captured data as a particular format
46a9ac7
@danielbachhuber
Ensure ::runcommand() exits on error by default
603889e
@danielbachhuber
Explicit error code assertions
025e4e8
@danielbachhuber
Use ::runcommand() inside of wp rewrite structure
bf6c7c0
@danielbachhuber
Permit overriding exit on error behavior in the same process
1668a27
@danielbachhuber
Update PHPDoc
2b3f0d4
@danielbachhuber
Use WP_CLI::halt() to overload halting script execution
7b2ce30
@danielbachhuber
Only overload the logger when we want to return output
a5ac336
@danielbachhuber danielbachhuber merged commit b2dfe03 into master Nov 27, 2016
@danielbachhuber danielbachhuber deleted the 3139-runcommand branch November 27, 2016 03:11
@danielbachhuber danielbachhuber mentioned this pull request Nov 29, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

internal-api:wp-cli-run-command scope:framework

Projects

None yet

Milestone

1.0.0

Development

Successfully merging this pull request may close these issues.

1 participant

@danielbachhuber