Skip to content

Verify release hash when updating #3515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielbachhuber merged 1 commit into from
Nov 2, 2016
Merged

Verify release hash when updating #3515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions features/cli.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,10 @@ Feature: `wp cli` tasks

When I run `{PHAR_PATH} cli update --yes`
Then STDOUT should contain:
"""
md5 hash verified:
"""
And STDOUT should contain:
"""
Success:
"""
Expand Down Expand Up @@ -73,9 +77,13 @@ Feature: `wp cli` tasks

When I run `{PHAR_PATH} cli update --patch --yes`
Then STDOUT should contain:
"""
Success: Updated WP-CLI to 0.14.1
"""
"""
md5 hash verified: 3f5fa2fda8457a9a5dc9875f17a3716d
"""
And STDOUT should contain:
"""
Success: Updated WP-CLI to 0.14.1
"""
And STDERR should be empty
And the return code should be 0

Expand Down Expand Up @@ -108,6 +116,10 @@ Feature: `wp cli` tasks

When I run `{PHAR_PATH} cli update --nightly --yes`
Then STDOUT should contain:
"""
md5 hash verified:
"""
And STDOUT should contain:
"""
Success: Updated WP-CLI to the latest nightly release.
"""
Expand All @@ -133,6 +145,10 @@ Feature: `wp cli` tasks
"""
You have version 0.14.0. Would you like to update to the latest stable release? [y/n]
"""
And STDOUT should contain:
"""
md5 hash verified:
"""
And STDOUT should contain:
"""
Success: Updated WP-CLI to the latest stable release.
Expand Down
16 changes: 15 additions & 1 deletion php/commands/cli.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,9 +241,11 @@ public function update( $_, $assoc_args ) {
if ( Utils\get_flag_value( $assoc_args, 'nightly' ) ) {
WP_CLI::confirm( sprintf( 'You have version %s. Would you like to update to the latest nightly?', WP_CLI_VERSION ), $assoc_args );
$download_url = 'https://raw.githubusercontent.com/wp-cli/builds/gh-pages/phar/wp-cli-nightly.phar';
$md5_url = 'https://raw.githubusercontent.com/wp-cli/builds/gh-pages/phar/wp-cli-nightly.phar.md5';
} else if ( Utils\get_flag_value( $assoc_args, 'stable' ) ) {
WP_CLI::confirm( sprintf( 'You have version %s. Would you like to update to the latest stable release?', WP_CLI_VERSION ), $assoc_args );
$download_url = 'https://raw.githubusercontent.com/wp-cli/builds/gh-pages/phar/wp-cli.phar';
$md5_url = 'https://raw.githubusercontent.com/wp-cli/builds/gh-pages/phar/wp-cli.phar.md5';
} else {

$updates = $this->get_updates( $assoc_args );
Expand All @@ -259,7 +261,7 @@ public function update( $_, $assoc_args ) {
WP_CLI::confirm( sprintf( 'You have version %s. Would you like to update to %s?', WP_CLI_VERSION, $newest['version'] ), $assoc_args );

$download_url = $newest['package_url'];

$md5_url = str_replace( '.phar', '.phar.md5', $download_url );
}

WP_CLI::log( sprintf( 'Downloading from %s...', $download_url ) );
Expand All @@ -274,6 +276,18 @@ public function update( $_, $assoc_args ) {

Utils\http_request( 'GET', $download_url, null, $headers, $options );

$md5_response = Utils\http_request( 'GET', $md5_url );
if ( 20 != substr( $md5_response->status_code, 0, 2 ) ) {
WP_CLI::error( "Couldn't access md5 hash for release (HTTP code {$md5_response->status_code})." );
}
$md5_file = md5_file( $temp );
$release_hash = trim( $md5_response->body );
if ( $md5_file === $release_hash ) {
WP_CLI::log( 'md5 hash verified: ' . $release_hash );
} else {
WP_CLI::error( "md5 hash for download ({$md5_file}) is different than the release hash ({$release_hash})." );
}

$allow_root = WP_CLI::get_runner()->config['allow-root'] ? '--allow-root' : '';
$php_binary = WP_CLI::get_php_binary();
$process = WP_CLI\Process::create( "{$php_binary} $temp --info {$allow_root}" );
Expand Down