Skip to content

Ensure WP_INSTALLING is set for wp core update-db #3503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielbachhuber merged 2 commits into from
Oct 28, 2016
Merged

Ensure WP_INSTALLING is set for wp core update-db #3503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c24fce7
Ensure `WP_INSTALLING` is set for `wp core update-db`
danielbachhuber Oct 26, 2016
c8efe12
Fix conditional. Fortunately, this caused a lot of tests to break.
danielbachhuber Oct 26, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions features/core-update-db.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,3 +88,19 @@ Feature: Update core's database
"""
Success: WordPress database upgraded on 3/3 sites.
"""

Scenario: Ensure update-db sets WP_INSTALLING constant
Given a WP install
And a before.php file:
"""
<?php
WP_CLI::add_hook( 'before_invoke:core update-db', function(){
WP_CLI::log( 'WP_INSTALLING: ' . var_export( WP_INSTALLING, true ) );
});
"""

When I run `wp --require=before.php core update-db`
Then STDOUT should contain:
"""
WP_INSTALLING: true
"""
3 changes: 2 additions & 1 deletion php/WP_CLI/Runner.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -875,7 +875,8 @@ public function start() {
exit;
}

if ( $this->cmd_starts_with( array( 'core', 'is-installed' ) ) ) {
if ( $this->cmd_starts_with( array( 'core', 'is-installed' ) )
|| $this->cmd_starts_with( array( 'core', 'update-db' ) ) ) {
define( 'WP_INSTALLING', true );
}

Expand Down