Proper coding style for wp-config#3496
Merged
Merged
Conversation
We don't have to copy ugliness.
Member
|
@szepeviktor Can you update the appropriate tests please? |
Member
|
@szepeviktor Looks like the build is still failing. |
Contributor
Author
|
OK. Running home-travis :) |
Contributor
Author
|
This is not me :( |
Contributor
Author
|
It has something to do with WP version < 4.0 Lines 382 to 386 in 4f6b9b4 |
Contributor
Author
SummaryUp to this PR the I suggest to remove |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't have to copy ugliness.