Skip to content

improve bash completion#3492

Merged
danielbachhuber merged 4 commits into
wp-cli:masterfrom
miya0001:improve-bash-completion
Oct 25, 2016
Merged

improve bash completion#3492
danielbachhuber merged 4 commits into
wp-cli:masterfrom
miya0001:improve-bash-completion

Conversation

@miya0001
Copy link
Copy Markdown
Member

@miya0001 miya0001 commented Oct 24, 2016

When I run following

$ wp core[tab]

It should complement like following.

$ wp core[space]

And when I run following.

$ wp core[space][tab][tab]

It should complement like following.

$ wp core[space]
check-update        install             multisite-convert   update-db 
config              is-installed        multisite-install   verify-checksums 
download            language            update              version

Thanks!

@danielbachhuber danielbachhuber added this to the 0.25.0 milestone Oct 24, 2016
@miya0001
Copy link
Copy Markdown
Member Author

miya0001 commented Oct 24, 2016

@danielbachhuber

I moved some tests for bash completion from features/flags.feature to features/cli-bash-completion.feature.

And update tests like following, because space at the end of the line will be removed by .editorconfig.
https://github.com/wp-cli/wp-cli/blob/master/.editorconfig#L13

Before:

    Then STDOUT should be:
      """
      eval 
      eval-file 
      """

After:

    Then STDOUT should contain:
      """
      eval
      """
    And STDOUT should contain:
      """
      eval-file
      """

@danielbachhuber
Copy link
Copy Markdown
Member

danielbachhuber commented Oct 24, 2016

@miya0001 Sounds good.

@danielbachhuber danielbachhuber merged commit 018d8ee into wp-cli:master Oct 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

scope:framework

Projects

None yet

Milestone

0.25.0

Development

Successfully merging this pull request may close these issues.

2 participants

@miya0001 @danielbachhuber