Skip to content

Introduce parameter in option list to negate search #3455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielbachhuber merged 2 commits into from
Oct 5, 2016
Merged

Introduce parameter in option list to negate search #3455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
877fa4a
Add exclude parameter in option list
ernilambar Oct 5, 2016
6802d98
Add test for exclude pattern in option list
ernilambar Oct 5, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions features/option-list.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,36 @@ Feature: List WordPress options
"""
siteurl
"""

Scenario: List option with exclude pattern
Given a WP install

When I run `wp option add sample_test_field_one sample_test_field_value_one`
And I run `wp option add sample_test_field_two sample_test_field_value_two`
And I run `wp option list --search="sample_test_field_*" --format=csv`
Then STDOUT should be:
"""
option_name,option_value
sample_test_field_one,sample_test_field_value_one
sample_test_field_two,sample_test_field_value_two
"""

When I run `wp option list --search="sample_test_field_*" --exclude="*field_one" --format=csv`
Then STDOUT should be:
"""
option_name,option_value
sample_test_field_two,sample_test_field_value_two
"""

When I run `wp option list`
Then STDOUT should contain:
"""
sample_test_field_one
"""

When I run `wp option list --exclude="sample_test_field_one"`
Then STDOUT should not contain:
"""
sample_test_field_one
"""

14 changes: 14 additions & 0 deletions php/commands/option.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,9 @@ public function add( $args, $assoc_args ) {
* [--search=<pattern>]
* : Use wildcards ( * and ? ) to match option name.
*
* [--exclude=<pattern>]
* : Pattern to exclude. Use wildcards ( * and ? ) to match option name.
*
* [--autoload=<value>]
* : Match only autoload options when value is on, and only not-autoload option when off.
*
Expand Down Expand Up @@ -202,6 +205,7 @@ public function list_( $args, $assoc_args ) {

global $wpdb;
$pattern = '%';
$exclude = '';
$fields = array( 'option_name', 'option_value' );
$size_query = ",LENGTH(option_value) AS `size_bytes`";
$autoload_query = '';
Expand All @@ -213,6 +217,12 @@ public function list_( $args, $assoc_args ) {
$pattern = str_replace( '?', '_', $pattern );
}

if ( isset( $assoc_args['exclude'] ) ) {
$exclude = self::esc_like( $assoc_args['exclude'] );
$exclude = str_replace( '*', '%', $exclude );
$exclude = str_replace( '?', '_', $exclude );
}

if ( isset( $assoc_args['fields'] ) ) {
$fields = explode( ',', $assoc_args['fields'] );
}
Expand Down Expand Up @@ -245,6 +255,10 @@ public function list_( $args, $assoc_args ) {
if ( $pattern ) {
$where .= $wpdb->prepare( "WHERE `option_name` LIKE %s", $pattern );
}

if ( $exclude ) {
$where .= $wpdb->prepare( " AND `option_name` NOT LIKE %s", $exclude );
}
$where .= $autoload_query . $transients_query;

$results = $wpdb->get_results( "SELECT `option_name`,`option_value`,`autoload`" . $size_query
Expand Down