Handle dead_db() error on nocache_headers filter#3440
Merged
Conversation
WordPress conveniently calls `nocache_headers()` inside of `dead_db()`, which means we can swoop in and display the database error ourselves. `enable_wp_debug_mode_checks` is too early, because `wp_die()` isn't yet defined for `$wpdb` to call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WordPress conveniently calls
nocache_headers()inside ofdead_db(),which means we can swoop in and display the database error ourselves.
enable_wp_debug_mode_checksis too early, becausewp_die()isn't yetdefined for
$wpdbto call.Fixes #3433