Add a simple progress indicator to wp media regenerate#3407
Merged
danielbachhuber merged 3 commits intoSep 23, 2016
Conversation
|
|
||
| if ( empty( $metadata ) ) { | ||
| WP_CLI::warning( "Couldn't regenerate thumbnails for $att_desc." ); | ||
| WP_CLI::warning( "$progress Couldn't regenerate thumbnails for $att_desc." ); |
Member
There was a problem hiding this comment.
Does $progress ever remain empty?
Member
There was a problem hiding this comment.
... because, if it does, then we'd end up with an empty space before "Couldn't"
Contributor
Author
There was a problem hiding this comment.
I removed the default argument value in 01bebd9, so I should never be empty now.
Member
|
@nyordanov Looks good, just one question. |
This was referenced Oct 17, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
$current/$countprefix towp media regenerate's progress logs.