Implement wp db check#3278
Conversation
| Then the return code should be 1 | ||
|
|
||
| When I run `wp db check` | ||
| Then STDOUT should not be empty |
There was a problem hiding this comment.
Can you improve this test to:
Then STDOUT should be:
And verify the output is what's expected?
There was a problem hiding this comment.
I was encouraged by the other two tests.
Does this seem OK?
wp_cli_test.wp_commentmeta OK
wp_cli_test.wp_comments OK
wp_cli_test.wp_links OK
wp_cli_test.wp_options OK
wp_cli_test.wp_postmeta OK
wp_cli_test.wp_posts OK
wp_cli_test.wp_term_relationships OK
wp_cli_test.wp_term_taxonomy OK
wp_cli_test.wp_termmeta OK
wp_cli_test.wp_terms OK
wp_cli_test.wp_usermeta OK
wp_cli_test.wp_users OK
There was a problem hiding this comment.
Does this seem OK?
Yep.
There was a problem hiding this comment.
Ok. That's off-topic for the pull request, and not really appropriate for the project. I'm going to delete the comment. Please keep conversations on-topic.
There was a problem hiding this comment.
OK :( Let's be serious.
|
@danielbachhuber Do you have an idea why PHP7 eats the output? |
Nope :( |
|
Do we have another another test that tests STDOUT? *with external command |
|
My fault. |
|
I have no clue... |
|
When I run |
|
@danielbachhuber Could you run wp db check yourself? |
|
I tried this PR. In Terminal, I got expected output. But in Behat test, table output is not there, only |
|
@danielbachhuber Are you a Behat expert? |
Not necessarily. Sorry I haven't taken the time to debug this yet. I'll try to make time to do so in the near future. |
|
I am trying to find the solution before you. |
|
Closing in favor of #3332 |
|
3ce2409 is not fair. Behat has a problem, I don't know what it is. It swallows stdout. +36204242498 On August 22, 2016 10:32:49 PM CEST, Daniel Bachhuber notifications@github.com wrote:
|
Hm, not locally according to d687049 |
Closes #3273