Skip to content

Don't trigger cron when ALTERNATE_WP_CRON is defined #3118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielbachhuber merged 2 commits into from
Jul 7, 2016
Merged

Don't trigger cron when ALTERNATE_WP_CRON is defined #3118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
acbf549
Failing test case for #3104
danielbachhuber Jul 7, 2016
99dea0f
Don't trigger cron when ALTERNATE_WP_CRON is defined
danielbachhuber Jul 7, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions features/cron.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,3 +280,27 @@ Feature: Manage WP-Cron events and schedules
"""
Executed a total of 0 cron event(s)
"""

Scenario: Don't trigger cron when ALTERNATE_WP_CRON is defined
Given a alternate-wp-cron.php file:
"""
<?php
define( 'ALTERNATE_WP_CRON', true );
"""
And a wp-cli.yml file:
"""
require:
- alternate-wp-cron.php
"""

When I run `wp eval 'var_export( ALTERNATE_WP_CRON );'`
Then STDOUT should be:
"""
true
"""

When I run `wp option get home`
Then STDOUT should be:
"""
http://example.com
"""
7 changes: 7 additions & 0 deletions php/WP_CLI/Runner.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1014,6 +1014,13 @@ private function setup_bootstrap_hooks() {
return $headers;
});

// ALTERNATE_WP_CRON might trigger a redirect, which we can't handle
if ( defined( 'ALTERNATE_WP_CRON' ) && ALTERNATE_WP_CRON ) {
$this->add_wp_hook( 'muplugins_loaded', function() {
remove_action( 'init', 'wp_cron' );
});
}

// Get rid of warnings when converting single site to multisite
if ( defined( 'WP_INSTALLING' ) && $this->is_multisite() ) {
$values = array(
Expand Down