Skip to content

Fix exception in menu list command if the format is ids #3074 #3075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielbachhuber merged 4 commits into from
Jun 28, 2016
Merged

Fix exception in menu list command if the format is ids #3074 #3075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
27d6fee
Fix exception in menu list command if the format is ids #3074
apertureless Jun 28, 2016
7005f83
Fix formatting
apertureless Jun 28, 2016
8a99f55
Add feature test for wp menu item list with format ids
apertureless Jun 28, 2016
7388bf5
Change array_column to array_map method because of compatibility
apertureless Jun 28, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions features/menu.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,13 @@ Feature: Manage WordPress menus
0
"""

When I run `wp menu create "First Menu"`
And I run `wp menu list --format=ids`
Then STDOUT should be:
"""
5
"""

Scenario: Assign / remove location from a menu

When I run `wp theme install p2 --activate`
Expand Down
11 changes: 10 additions & 1 deletion php/commands/menu.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,8 +183,17 @@ public function list_( $_, $assoc_args ) {
}

$formatter = $this->get_formatter( $assoc_args );
$formatter->display_items( $menus );

if ( 'ids' == $formatter->format ) {
$ids = array_map(
function($o) {
return $o->term_id;
}, $menus
);
$formatter->display_items( $ids );
} else {
$formatter->display_items( $menus );
}
}

protected function get_formatter( &$assoc_args ) {
Expand Down