Skip to content

Accept multiple term IDs in term url#2865

Merged
danielbachhuber merged 4 commits into
wp-cli:masterfrom
ernilambar:2863-issue-term-url
May 30, 2016
Merged

Accept multiple term IDs in term url#2865
danielbachhuber merged 4 commits into
wp-cli:masterfrom
ernilambar:2863-issue-term-url

Conversation

@ernilambar
Copy link
Copy Markdown
Member

See #2863

@danielbachhuber
Copy link
Copy Markdown
Member

@ernilambar Can you include updated tests please?

@ernilambar
Copy link
Copy Markdown
Member Author

@danielbachhuber Can you please check the build result? What did I do wrong :-)
https://travis-ci.org/wp-cli/wp-cli/jobs/133088641#L295

@danielbachhuber
Copy link
Copy Markdown
Member

@ernilambar Does it fail locally?

@ernilambar
Copy link
Copy Markdown
Member Author

@danielbachhuber I have fixed the test. I had used two STDOUT variables {TERM_ID_1} and {TERM_ID_2}. But somehow ``{TERM_ID_2}` was not being replaced with the term ID. So that was giving WP_Error.

@danielbachhuber danielbachhuber merged commit 26b76db into wp-cli:master May 30, 2016
@ernilambar ernilambar deleted the 2863-issue-term-url branch May 30, 2016 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants