Custom WP Loading#261
Merged
Merged
Conversation
Frustratingly, wp-config.php insists on defining ABSPATH and on require()ing wp-settings.php. So, we comb through each line of code from wp-config.php, skipping what we don't like, and then we explicitly eval() the result. Afterwards, we're free to require() our own version of wp-settings.php etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're going to roll our own version of wp-settings.php, which will give us a lot more control over the initialization, like what happens when the DB tables aren't installed. Should help with #93 and probably #177 too.
The downside would be that we'll have to be more conservative over which versions of WP we'll support, since our version of
wp-settings.phpwill have to be compatible with all of them.