Add newline to wp shell's prompt#2601
Merged
Merged
Conversation
| \Psy\Shell::debug(); | ||
| } else { | ||
| $repl = new $class( 'wp> ' ); | ||
| $repl = new $class( "\nwp> " ); |
Member
There was a problem hiding this comment.
@JRGould I noticed this adds a newline when the shell first begins too. Is there a way of preventing this?
Contributor
Author
There was a problem hiding this comment.
Could probably add a flag to \WP_CLI\REPL and strip out the newline just the first time the prompt is printed. Not sure about Psy or Boris though. Happy to open another issue/PR for that if you think it's worth the tinker?
Member
There was a problem hiding this comment.
Happy to open another issue/PR for that if you think it's worth the tinker?
Yes please. We should also look into whether we can inject the newline after command execution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2600