Skip to content

Core updates should be stored in the cache directory#1320

Merged
danielbachhuber merged 9 commits into
masterfrom
cache-update
Aug 22, 2014
Merged

Core updates should be stored in the cache directory#1320
danielbachhuber merged 9 commits into
masterfrom
cache-update

Conversation

@danielbachhuber
Copy link
Copy Markdown
Member

I ran wp core update for 3.9.1 => 3.9.2 on ~75 sites on my server.
The upgrade files were not stored in .wp-cli/cache/core, and it appeared that a fresh download of the changed files were downloaded for each of the 75 sites.

message in CLI was:
Downloading update from https://downloads.wordpress.org/release/wordpress-3.9.2-partial-1.zip
Unpacking the update...
Success: WordPress updated successfully

Re-tested after clearing .wp-cli/cache/core and no new files were placed there.

@danielbachhuber
Copy link
Copy Markdown
Member

The cache is only used in wp core download, not wp core update. It would make sense to have for the latter too.

@danielbachhuber danielbachhuber changed the title Core update not stored in cache directory Core updates should be stored in the cache directory Aug 21, 2014
@danielbachhuber danielbachhuber added this to the next milestone Aug 21, 2014
@danielbachhuber
Copy link
Copy Markdown
Member

@scribu any better ideas for extending than subclassing if the filter doesn't exist?

@scribu
Copy link
Copy Markdown
Member

scribu commented Aug 21, 2014

Well, you could just drop support for WP 3.5 and WP 3.6.

@danielbachhuber
Copy link
Copy Markdown
Member

Well, you could just drop support for WP 3.5 and WP 3.6.

Meh, the workaround is easy enough.

danielbachhuber added a commit that referenced this pull request Aug 22, 2014
Core updates should be stored in the cache directory
@danielbachhuber danielbachhuber merged commit 79d5517 into master Aug 22, 2014
@danielbachhuber danielbachhuber deleted the cache-update branch August 22, 2014 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants