Add esc_sql_ident(), catering for reserved word column names.#23
Merged
Conversation
Member
|
@gitlost Are you ready for a review on this or is it on hold? |
schlessera
approved these changes
Aug 14, 2017
danielbachhuber
pushed a commit
that referenced
this pull request
Nov 18, 2022
Add esc_sql_ident(), catering for reserved word column names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #4
Adds
esc_sql_ident()func to backtick column/table names and uses it throughout, though the only real fixes (excluding the unlikely case of backticks in column/table names) is inphp_handle_col(), where primary keys weren't escaped, as mentioned in the original PR, andesc_sql()was used for$col_sql.(A similar fix needs to be done for
db search.)Also adds note about the double escaping in the WP <= 3.9 part of
esc_like()which I thought was wrong but turns out to be necessary.