Clarify "please flush object cache" message in multisite to mention cached lookup value#21
Merged
Merged
Conversation
danielbachhuber
requested changes
Aug 4, 2017
| $success_message = "Made $total replacements."; | ||
| if ( $total && 'Default' !== WP_CLI\Utils\wp_get_cache_type() ) { | ||
| $success_message .= ' Please remember to flush your persistent object cache with `wp cache flush`.'; | ||
| $success_message .= ' Please remember to flush your persistent object cache with `wp cache flush`. If you see a "Site not found" error after replacing a domain, try flushing cache against the old domain (which may be the cached lookup value).'; |
Member
There was a problem hiding this comment.
The "If you see..." clarification should only be included when is_multisite() is true, because it's not applicable for single site.
schlessera
requested changes
Aug 6, 2017
Member
schlessera
left a comment
There was a problem hiding this comment.
@Sidsector9 Instead of having the first sentence twice, you should add the first sentence without a conditional, and then add the second sentence for is_multisite().
Member
Author
|
@schlessera You're right, I missed it! Changes made. |
schlessera
requested changes
Aug 6, 2017
| $success_message = "Made $total replacements."; | ||
| if ( $total && 'Default' !== WP_CLI\Utils\wp_get_cache_type() ) { | ||
| $success_message .= ' Please remember to flush your persistent object cache with `wp cache flush`.'; | ||
| $success_message .= ' Please remember to flush your persistent object cache with `wp cache flush`.'; |
schlessera
approved these changes
Aug 6, 2017
danielbachhuber
approved these changes
Aug 8, 2017
danielbachhuber
added a commit
that referenced
this pull request
Nov 18, 2022
Clarify "please flush object cache" message in multisite to mention cached lookup value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12