Skip to content

Suppress error in search-replace-export.feature.#16

Merged
danielbachhuber merged 1 commit into
masterfrom
suppress_error_log
Jul 13, 2017
Merged

Suppress error in search-replace-export.feature.#16
danielbachhuber merged 1 commit into
masterfrom
suppress_error_log

Conversation

@gitlost
Copy link
Copy Markdown
Contributor

@gitlost gitlost commented Jul 13, 2017

Adds suppress-error-log.php to search-replace-export.feature:154 stop notice getting written to error_log.

@gitlost gitlost requested a review from a team July 13, 2017 09:58
@danielbachhuber danielbachhuber added this to the 1.0.3 milestone Jul 13, 2017
@danielbachhuber danielbachhuber added the scope:testing Related to testing label Jul 13, 2017
@danielbachhuber
Copy link
Copy Markdown
Member

stop notice getting written to error_log.

Is this a problem with all of our tests?

@gitlost
Copy link
Copy Markdown
Contributor Author

gitlost commented Jul 13, 2017

Just ones that cause wp-cli to give a notice. I don't think there's that many.

@danielbachhuber danielbachhuber merged commit 7449550 into master Jul 13, 2017
@danielbachhuber danielbachhuber deleted the suppress_error_log branch July 13, 2017 12:05
@gitlost
Copy link
Copy Markdown
Contributor Author

gitlost commented Jul 13, 2017

Actually a better option here which I should have thought of would be to suppress the notice in wp-cli with @fopen()...

danielbachhuber added a commit that referenced this pull request Aug 28, 2017
Suppress error on fopen export file, revert PR #16.
danielbachhuber added a commit that referenced this pull request Nov 18, 2022
Suppress error in search-replace-export.feature.
danielbachhuber added a commit that referenced this pull request Nov 18, 2022
Suppress error on fopen export file, revert PR #16.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope:testing Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants