Cater for symbolic links. Add canonicalize_path and use in check_target_directory.#26
Merged
Merged
Conversation
danielbachhuber
requested changes
Jun 12, 2017
|
|
||
| if ( in_array( $theme_slug, array( '.', '..' ) ) ) { | ||
| WP_CLI::error( "Invalid theme slug specified." ); | ||
| WP_CLI::error( "Invalid theme slug specified. The slug cannot be \".\" or \"..\"." ); |
Member
There was a problem hiding this comment.
One minor nit. Is there a reason you went with double quotes instead of single quotes? If I recall correctly, we use single quotes pretty consistently elsewhere.
Contributor
Author
There was a problem hiding this comment.
That's single quotes as in "Invalid theme slug specified. The slug cannot be '.' or '..'." (not the PHP string itself) I presume?!
danielbachhuber
approved these changes
Jun 14, 2017
danielbachhuber
added a commit
that referenced
this pull request
Nov 18, 2022
Cater for symbolic links. Add canonicalize_path and use in check_target_directory.
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #22
Adds
canonicalize_path()and uses incheck_target_directory()in place ofrealpath()to avoid symbolic link issues.Adds some feedback by appending various reasons to the "Invalid plugin/theme slug specified." error messages. Involves changing
check_target_directory()to return error string instead of bool.