Skip to content

Support --post_name=<name> when importing media#166

Merged
danielbachhuber merged 2 commits into
wp-cli:masterfrom
mpkelly:add/post_name_param
Nov 15, 2022
Merged

Support --post_name=<name> when importing media#166
danielbachhuber merged 2 commits into
wp-cli:masterfrom
mpkelly:add/post_name_param

Conversation

@mpkelly
Copy link
Copy Markdown
Contributor

@mpkelly mpkelly commented Nov 15, 2022

Fixes #100

A small PR to pass through the --post_name param. It was my "bottle" from the pickup session. I've updated the test suite, so hopefully should be straightforward to test and review.

@mpkelly mpkelly requested a review from a team as a code owner November 15, 2022 00:22
@danielbachhuber danielbachhuber added command:media Related to 'media' command command:media-import Related to 'media import' command labels Nov 15, 2022
@danielbachhuber danielbachhuber added this to the 2.0.16 milestone Nov 15, 2022
Copy link
Copy Markdown
Member

@danielbachhuber danielbachhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this, @mpkelly !

@danielbachhuber danielbachhuber merged commit e3c7506 into wp-cli:master Nov 15, 2022
danielbachhuber added a commit that referenced this pull request Nov 18, 2022
* Support adding post_name param

* Fix PHPCS issues

Co-authored-by: Daniel Bachhuber <daniel.bachhuber@automattic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

command:media Related to 'media' command command:media-import Related to 'media import' command

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support --post_name=<name> for importing media

2 participants