Escape regex dots when stripping .min suffix#457
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Member
|
Good catch! Thanks for the PR. At first glsnce a separate test class just for this one line change is a bit overkill. Could we just add another Behag test case instead? |
Contributor
Author
|
You're absolutely right! A separate test class for testing one regex line is indeed overkill. I've removed the PHPUnit test and added a simple Behat test case instead. |
.min to prevent filename truncation.min suffix
swissspidy
approved these changes
Oct 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an incorrect regex replacement that caused generated translation file hashes not to match WordPress’ expectations.
Fixes #456
Problem
The code used the following expression when stripping
.minfrom file names:Because the
.characters were not escaped, the regex matched any character, not a literal dot.Example:
my-plugin-admin.js"dmin."(because.matchedd)my-plugin-a.jsThis resulted in WordPress computing the wrong hash for the script source, so it tried to load a non-existent JSON translation file. As a result, JavaScript translations were never found.
Fix
Escape the dot characters in the regex so they are treated literally:
Now only
.min.js(or the correct extension) is matched, and file names remain intact (my-plugin-admin.js). The translation JSON filenames are generated with the correct hash and translations load as expected.