Skip to content

Adjust user tests 'spamed' -> 'spammed'.#90

Merged
schlessera merged 2 commits into
masterfrom
issue_89
Sep 17, 2017
Merged

Adjust user tests 'spamed' -> 'spammed'.#90
schlessera merged 2 commits into
masterfrom
issue_89

Conversation

@gitlost

@gitlost gitlost commented Sep 16, 2017

Copy link
Copy Markdown
Contributor

Issue #89

Related PRs wp-cli/wp-cli#4351 and #74

Adjusts user spam tests past tense spamed -> spammed.

@gitlost gitlost added command:user-spam Related to 'user spam' command bug scope:testing Related to testing labels Sep 16, 2017
@gitlost gitlost added this to the 1.1.0 milestone Sep 16, 2017

@schlessera schlessera left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the changes to .gitignore and composer.json ?

@gitlost

gitlost commented Sep 16, 2017

Copy link
Copy Markdown
Contributor Author

Sorry the .gitignore change was me trying to sneak in vi friendliness. The composer.json change I thought was necessary but forgot about the composer require wp-cli/wp-cli:dev-master in .travis.yml. I've removed both.

@schlessera

Copy link
Copy Markdown
Member

For stuff like the vi files, you should put rules into your global git ignore file instead: https://help.github.com/articles/ignoring-files/#create-a-global-gitignore

Just do this once, and you'll never have to worry about them again.

@schlessera schlessera merged commit 67d1bfc into master Sep 17, 2017
@schlessera schlessera deleted the issue_89 branch September 17, 2017 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug command:user-spam Related to 'user spam' command scope:testing Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants