Skip to content

Fix: wp menu item update --position does not reshuffle other menu items #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swissspidy merged 11 commits into from
Mar 19, 2026
Merged

Fix: wp menu item update --position does not reshuffle other menu items #603

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3415575
Initial plan
Copilot Mar 18, 2026
e175a73
Fix position not updated in wp menu item update command
Copilot Mar 18, 2026
d1110f1
Fix position update: reorder items before wp_update_nav_menu_item call
Copilot Mar 18, 2026
3245ddc
Fix: reorder menu items using normalized rank-based wp_update_post in…
Copilot Mar 18, 2026
5c4a0a2
Lint fixes
swissspidy Mar 18, 2026
dc9a903
Potential fix for pull request finding
swissspidy Mar 18, 2026
67bc91b
Potential fix for pull request finding
swissspidy Mar 18, 2026
bb9e9b2
Potential fix for pull request finding
swissspidy Mar 18, 2026
c7dfdf0
Apply suggestions from code review
swissspidy Mar 19, 2026
033baf2
PHPCS fix
swissspidy Mar 19, 2026
5666a6f
Fix: normalize IDs to int after get_posts fields=ids to fix strict ar…
Copilot Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Lint fixes
  • Loading branch information
@swissspidy
swissspidy committed Mar 18, 2026
commit 5c4a0a2e09907283e73f53a21b0d03cacc6aae7d
27 changes: 6 additions & 21 deletions src/Menu_Item_Command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -645,12 +645,12 @@ private function add_or_update_item( $method, $type, $args, $assoc_args ) {
// normalises menu_order to 1,2,3… which may differ from the raw DB values.
$sorted_items = get_posts(
[
Comment thread
swissspidy marked this conversation as resolved.
'post_type' => 'nav_menu_item',
'numberposts' => -1,
'orderby' => 'menu_order',
'order' => 'ASC',
'post_status' => 'any',
'tax_query' => [
'post_type' => 'nav_menu_item',
'numberposts' => -1,
'orderby' => 'menu_order',
'order' => 'ASC',
'post_status' => 'any',
'tax_query' => [
[
'taxonomy' => 'nav_menu',
'field' => 'term_taxonomy_id',
Expand Down Expand Up @@ -749,21 +749,6 @@ private function reorder_menu_items( $menu_id, $min_position, $increment, $ignor
return $wpdb->query( $wpdb->prepare( "UPDATE $wpdb->posts SET `menu_order`=`menu_order`+(%d) WHERE `menu_order`>=%d AND ID IN (SELECT object_id FROM $wpdb->term_relationships WHERE term_taxonomy_id=%d) AND ID<>%d", (int) $increment, (int) $min_position, (int) $menu_id, (int) $ignore_item_id ) );
}

/**
* Move a range of items in one nav_menu up or down by incrementing/decrementing their menu_order field.
* Only affects items with menu_order between min_position and max_position (inclusive).
*
* @param int $menu_id ID of the nav_menu
* @param int $min_position minimal menu_order to touch (inclusive)
* @param int $max_position maximal menu_order to touch (inclusive)
* @param int $increment how much to change menu_order: +1 to move down, -1 to move up
* @return int|false number of rows affected, or false on failure
*/
private function reorder_menu_items_in_range( $menu_id, $min_position, $max_position, $increment ) {
global $wpdb;
return $wpdb->query( $wpdb->prepare( "UPDATE $wpdb->posts SET `menu_order`=`menu_order`+(%d) WHERE `menu_order` BETWEEN %d AND %d AND ID IN (SELECT object_id FROM $wpdb->term_relationships WHERE term_taxonomy_id=%d)", (int) $increment, (int) $min_position, (int) $max_position, (int) $menu_id ) );
}

protected function get_formatter( &$assoc_args ) {
return new Formatter( $assoc_args, $this->obj_fields );
}
Expand Down
Loading