Skip to content

Resolve tests failures from WordPress 6.2 #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielbachhuber merged 3 commits into from
Apr 10, 2023
Merged

Resolve tests failures from WordPress 6.2 #229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c3af0d6
Update test to use minor version with a download offer
danielbachhuber Apr 10, 2023
4bacd21
Remove test for esoteric condition that we can't reproduce
danielbachhuber Apr 10, 2023
87acac9
Remove the other test associated with the esoteric condition
danielbachhuber Apr 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions features/core-check-update.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,21 +40,3 @@ Feature: Check for more recent versions
"""
1
"""

Scenario: No minor updates for an unlocalized WordPress release
Given a WP install
And I try `wp theme install twentytwenty --activate`

# If current WP_VERSION is nightly, trunk or old then from checksums might not exist, so STDERR may or may not be empty.
When I try `wp core download --version=4.0 --locale=es_ES --force`
Then STDOUT should contain:
"""
Success: WordPress downloaded.
"""
And the return code should be 0

# WP core throws notice for PHP 8+.
When I try `wp core check-update --minor`
Then STDOUT should be a table containing rows:
| version | update_type | package_url |
| {WP_VERSION-4.0-latest} | minor | https://downloads.wordpress.org/release/wordpress-{WP_VERSION-4.0-latest}-partial-0.zip |
45 changes: 3 additions & 42 deletions features/core-update.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,23 +67,19 @@ Feature: Update WordPress core
Given a WP install
And I try `wp theme install twentytwenty --activate`

When I run `wp core download --version=3.9.9 --force`
When I run `wp core download --version=4.1.30 --force`
Then STDOUT should not be empty

# This version of WP throws a PHP notice
When I try `wp core update --minor`
Then STDOUT should contain:
"""
Updating to version {WP_VERSION-3.9-latest}
Updating to version {WP_VERSION-4.1-latest}
"""
And STDOUT should contain:
"""
Success: WordPress updated successfully.
"""
And STDERR should contain:
"""
Undefined variable
"""
And the return code should be 0

When I run `wp core update --minor`
Expand All @@ -95,7 +91,7 @@ Feature: Update WordPress core
When I run `wp core version`
Then STDOUT should be:
"""
{WP_VERSION-3.9-latest}
{WP_VERSION-4.1-latest}
"""

Scenario: Core update from cache
Expand Down Expand Up @@ -326,41 +322,6 @@ Feature: Update WordPress core
When I run `wp post create --post_title='Test post' --porcelain`
Then STDOUT should be a number

@less-than-php-7.3
Scenario: Minor update on an unlocalized WordPress release
Given a WP install
And I try `wp theme install twentytwenty --activate`
And an empty cache

# If current WP_VERSION is nightly, trunk or old then from checksums might not exist, so STDERR may or may not be empty.
When I try `wp core download --version=4.0 --locale=es_ES --force`
Then STDOUT should contain:
"""
Success: WordPress downloaded.
"""
And the return code should be 0

# No checksums available for this WP version/locale
Given I run `wp option set WPLANG es_ES`
When I try `wp core update --minor`
Then STDOUT should contain:
"""
Updating to version {WP_VERSION-4.0-latest} (en_US)...
"""
And STDOUT should contain:
"""
https://downloads.wordpress.org/release/wordpress-{WP_VERSION-4.0-latest}-partial-0.zip
"""
And STDOUT should contain:
"""
Success: WordPress updated successfully.
"""
And STDERR should be:
"""
Warning: Checksums not available for WordPress {WP_VERSION-4.0-latest}/es_ES. Please cleanup files manually.
"""
And the return code should be 0

@require-php-5.6
Scenario Outline: Use `--version=(nightly|trunk)` to update to the latest nightly version
Given a WP install
Expand Down