Skip to content

Update to wp-cli/wp-cli-tests:^4#42

Merged
swissspidy merged 4 commits into
mainfrom
update-wp-cli-tests-v4
Aug 30, 2023
Merged

Update to wp-cli/wp-cli-tests:^4#42
swissspidy merged 4 commits into
mainfrom
update-wp-cli-tests-v4

Conversation

@danielbachhuber
Copy link
Copy Markdown
Member

@danielbachhuber danielbachhuber commented Aug 30, 2023 •
edited
Loading

@danielbachhuber danielbachhuber added this to the 2.0.3 milestone Aug 30, 2023
@danielbachhuber danielbachhuber self-assigned this Aug 30, 2023
@danielbachhuber danielbachhuber requested a review from a team as a code owner August 30, 2023 11:58
@swissspidy
Copy link
Copy Markdown
Member

swissspidy commented Aug 30, 2023 

Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$wp_admin".

Should we perhaps disable that rule in the ruleset?

@danielbachhuber
Copy link
Copy Markdown
Member Author

danielbachhuber commented Aug 30, 2023

Should we perhaps disable that rule in the ruleset?

@swissspidy Fixed with 3f592b0

@swissspidy swissspidy merged commit e2e1635 into main Aug 30, 2023
@swissspidy swissspidy deleted the update-wp-cli-tests-v4 branch August 30, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swissspidy swissspidy swissspidy approved these changes

Assignees

@danielbachhuber danielbachhuber

Labels

scope:testing

Projects

None yet

Milestone

2.0.3

Development

Successfully merging this pull request may close these issues.

2 participants

@danielbachhuber @swissspidy