Restore self-describing names on the test jobs - #276
Conversation
The previous change moved the PHP version out of the called workflows and into the calling job, on the assumption that the run view renders a nested job as "<calling job> / <called job>". It does not at this depth. A nested job is labelled with its own name only, so the version was not moved, it was hidden. The result was a run full of jobs called "PHPUnit", and Behat legs called "WP trunk | SQLite" that gave no way to tell PHP 8.3 from 8.4 or 8.5. wp-cli/automated-tests appears to group because its matrix job is called directly from the top-level workflow, one level up from here. This repository has an extra level — testing.yml calls reusable-testing.yml, which calls reusable-unit.yml and reusable-functional.yml — and the middle name is not surfaced. Grouping by PHP version would require the matrix to live in each repository's testing.yml, which is exactly the per-repository file we decided not to centralise, so it is not reachable from here at all. Put the full description back in the called workflows, where it is displayed, and make the calling job names static again. The database version stays spelled out; that part fixed a real ambiguity where mysql-8.0 and mysql-8.4 rendered identically. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Jy4dmjymj9VmoTBaqrV4iX
|
Warning Review limit reached
Next review available in: 52 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Restores self-describing GitHub Actions job names for nested reusable workflows so CI runs remain readable (and uniquely identifiable) in consumer repositories that call these workflows at three levels of nesting.
Changes:
- Restore full, self-sufficient leg names in
reusable-unit.ymlandreusable-functional.yml(including PHP version). - Make the calling job names in
reusable-testing.ymlstatic again (Unit,Behat) and document why distinguishing detail must live in the leaf workflow job names.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/reusable-unit.yml | Updates the leaf job name to include `Unit |
| .github/workflows/reusable-testing.yml | Reverts caller job names to static Unit/Behat with an explanatory comment; continues passing matrix values to called workflows. |
| .github/workflows/reusable-functional.yml | Updates the leaf job name to include `Behat |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fixes a regression from #274. Because consumer repositories pin
@main, the bad names are live everywhere right now.What broke
#274 moved the PHP version out of the called workflows and into the calling job, on the assumption that the run view renders a nested job as
<calling job> / <called job>. It does not at this depth — a nested job is labelled with its own name only. The version was not moved, it was hidden.Observed in wp-cli/wp-cli-tests run 31163465254: nine jobs all called
PHPUnit, and Behat legs calledWP trunk | SQLitewith no way to tell PHP 8.3 from 8.4 from 8.5.Why the grouping is not reachable here
The idea came from
wp-cli/automated-tests, where the run groups neatly by package. That works because its matrix job is called directly from the top-level workflow — two levels, so the matrix job is the top-level caller and its name becomes the group header.This repository has three levels:
testing.yml→reusable-testing.yml→reusable-unit.yml/reusable-functional.yml. The middle name is not surfaced. Grouping by PHP version would require the matrix to live in each repository'stesting.yml— the per-repository file that carriesminimum-php,minimum-wpand thematrixoverrides, and which we deliberately kept out of the sync list. So it is not reachable without reopening that decision.What actually makes
automated-testsreadable is not the grouping, it is that its leaf name is self-sufficient. That is the property #274 broke.This change
reusable-unit.ymlandreusable-functional.yml, where it is displayed.reusable-testing.ymlstatic again (Unit,Behat), with a comment recording why detail must not go there.MySQLalone rendered the mysql-5.6, 5.7, 8.0 and 8.4 legs identically, which was seven pairs of check runs sharing a name.Verified by simulating the rendered names across the full pull request matrix: 41 Behat and 9 unit names, no duplicates.
Net effect against
main: names return to the pre-#274 format, plus the database version disambiguation.Generated by Claude Code