Skip to content

Expose connection_id on Profile Objects - #43

Merged
jthodge merged 4 commits into
masterfrom
feature/ch3597/python-sdk-support-connection-id-for-profile
Oct 14, 2020
Merged

jthodge merged 4 commits into
masterfrom
feature/ch3597/python-sdk-support-connection-id-for-profile

Conversation

@jthodge

@jthodge jthodge commented Oct 13, 2020

Copy link
Copy Markdown
Contributor

This PR introduces the following changes:

  • Passes the connection_id Profile object attribute through to the SDK. We currently expose connection_id via the /sso/token API endpoint.
  • Updates the SDK version to 0.8.0.

Comment thread workos/__about__.py
Comment thread tests/test_sso.py Outdated
@jthodge
jthodge requested a review from henrylamchan October 14, 2020 14:16
@codecov

codecov Bot commented Oct 14, 2020

Copy link
Copy Markdown

Codecov Report

Merging #43 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #43   +/-   ##
=======================================
  Coverage   94.50%   94.50%           
=======================================
  Files          14       14           
  Lines         273      273           
=======================================
  Hits          258      258           
  Misses         15       15           
Impacted Files Coverage Δ
workos/resources/sso.py 100.00% <ø> (ø)
workos/__about__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47421c2...bba847a. Read the comment docs.

@jthodge
jthodge merged commit 4998fb9 into master Oct 14, 2020
@jthodge
jthodge deleted the feature/ch3597/python-sdk-support-connection-id-for-profile branch October 14, 2020 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants